Re: wifi: airo: do not assign -1 to unsigned char

From: Kalle Valo
Date: Tue Nov 01 2022 - 05:15:33 EST


"Jason A. Donenfeld" <Jason@xxxxxxxxx> wrote:

> With char becoming unsigned by default, and with `char` alone being
> ambiguous and based on architecture, we get a warning when assigning the
> unchecked output of hex_to_bin() to that unsigned char. Mark `key` as a
> `u8`, which matches the struct's type, and then check each call to
> hex_to_bin() before casting.
>
> Cc: Kalle Valo <kvalo@xxxxxxxxxx>
> Cc: linux-wireless@xxxxxxxxxxxxxxx
> Signed-off-by: Jason A. Donenfeld <Jason@xxxxxxxxx>

Patch applied to wireless.git, thanks.

e6cb8769452e wifi: airo: do not assign -1 to unsigned char

--
https://patchwork.kernel.org/project/linux-wireless/patch/20221024162843.535921-1-Jason@xxxxxxxxx/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches