Re: [PATCH v3 1/5] dt-bindings: clock: Add QDU1000 and QRU1000 GCC clock bindings

[Krzysztof Kozlowski]

On 27/10/2022 17:28, Melody Olvera wrote:

>>>>> +      - description: Board XO source
>>>>> +      - description: Sleep clock source
>>>>> +      - description: PCIE 0 Pipe clock source
>>>>> +      - description: PCIE 0 Phy Auxiliary clock source
>>>>> +      - description: USB3 Phy wrapper pipe clock source
>>>>> +    minItems: 2
>>>> Why the clocks are optional?
>>> They should not be optional. They're always there.
>> Just to be sure - I refer to last three clocks here as indicated by
>> minItems:2.
>>
>> DTS does not define them, so something here is not complete or correct.
>>
> DT is incomplete; I don't have that in my current patchset. Will add later when PCIE and
> USB nodes are complete.

Bindings should be complete as much as possible, therefore please define
in the DTS stub clocks (fixed clocks) to fill these with a TODO notes.

Best regards,
Krzysztof