Re: [PATCH 6.0 00/20] 6.0.4-rc1 review

[Ernst Herzberg]

Missed a patch?

Problematic patch in v6.0.3 :

> commit 3ea7c50339859394dd667184b5b16eee1ebb53bc
> Author: Josef Bacik <josef@xxxxxxxxxxxxxx>
> Date:   Mon Aug 8 16:10:26 2022 -0400
>
>     btrfs: call __btrfs_remove_free_space_cache_locked on cache load failure
>     [ Upstream commit 8a1ae2781dee9fc21ca82db682d37bea4bd074ad ]
>     Now that lockdep is staying enabled through our entire CI runs I started
>     seeing the following stack in generic/475


See:

https://lore.kernel.org/stable/Y1aeWdHd4%2FluzhAu@localhost.localdomain/

> Well I definitely fucked this patch up, because I should have used the _locked
> variant, but this was part of a series where I did the correct thing in the next
> patch
>
>     btrfs: remove use btrfs_remove_free_space_cache instead of variant
>
> so this problem doesn't exist in linus.  So either we need to pull that back
> into stable as well, or drop this patch from stable.  I'm good either way, this
> was just to fix a lockdep splat so it's not really stable material, but I'll
> leave that decision up to y'all.  Thanks,
>
> Josef