Re: [PATCH 2/5] x86/microcode: Simplify init path even more

From: Ashok Raj
Date: Thu Oct 20 2022 - 11:09:15 EST


On Thu, Oct 20, 2022 at 10:18:01AM +0200, Borislav Petkov wrote:
> On Wed, Oct 19, 2022 at 09:37:59PM +0200, Borislav Petkov wrote:
> > Ah ok, yes, I need to check ->request_microcode_fw's retval.
>
> On a second thought, no I don't have to: the request routine will try to
> load any new microcode but if it fails, ->apply_microcode later simply
> won't find it in the cache. And that's perfectly fine.
>
> setup_online_cpu() still needs to run on each CPU unconditionally,
> though, in order to setup the sysfs groups.

That's true, its benign for this step.

I tried rebase everything I have, (i need to drop 2 of my patches after
your 5 patch series is applied on top of 6.1.0-rc1.

Everything works fine, which is good news.

Except I can't get this new load you added in microcode_init() to work.
It always gets UCODE_NFOUND.

- BIOS had version X
- Early applied Y > X
- I copied a new version Z > Y.

But i only see the early loaded version. I haven't looked at it yet, but
will try to look today.

Cheers,
Ashok