Re: [PATCH] arm64: remove special treatment for the link order of head.o

From: Nicolas Schier
Date: Thu Oct 13 2022 - 13:10:56 EST


On Thu, Oct 13, 2022 at 08:35:00AM +0900, Masahiro Yamada wrote:
> Date: Thu, 13 Oct 2022 08:35:00 +0900
> From: Masahiro Yamada <masahiroy@xxxxxxxxxx>
> To: Catalin Marinas <catalin.marinas@xxxxxxx>, Will Deacon
> <will@xxxxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Cc: linux-arch@xxxxxxxxxxxxxxx, Ard Biesheuvel <ardb@xxxxxxxxxx>, Masahiro
> Yamada <masahiroy@xxxxxxxxxx>, Nicolas Schier <nicolas@xxxxxxxxx>,
> linux-kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH] arm64: remove special treatment for the link order of
> head.o
> Message-Id: <20221012233500.156764-1-masahiroy@xxxxxxxxxx>
> X-Mailer: git-send-email 2.34.1
>
> In the previous discussion (see the Link tag), Ard pointed out that
> arm/arm64/kernel/head.o does not need any special treatment - the only
> piece that must appear right at the start of the binary image is the
> image header which is emitted into .head.text.
>
> The linker script does the right thing to do. The build system does
> not need to manipulate the link order of head.o.
>
> Link: https://lore.kernel.org/lkml/CAMj1kXH77Ja8bSsq2Qj8Ck9iSZKw=1F8Uy-uAWGVDm4-CG=EuA@xxxxxxxxxxxxxx/
> Suggested-by: Ard Biesheuvel <ardb@xxxxxxxxxx>
> Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
> ---

Reviewed-by: Nicolas Schier <nicolas@xxxxxxxxx>

> scripts/head-object-list.txt | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/scripts/head-object-list.txt b/scripts/head-object-list.txt
> index b16326a92c45..f226e45e3b7b 100644
> --- a/scripts/head-object-list.txt
> +++ b/scripts/head-object-list.txt
> @@ -15,7 +15,6 @@ arch/alpha/kernel/head.o
> arch/arc/kernel/head.o
> arch/arm/kernel/head-nommu.o
> arch/arm/kernel/head.o
> -arch/arm64/kernel/head.o
> arch/csky/kernel/head.o
> arch/hexagon/kernel/head.o
> arch/ia64/kernel/head.o
> --
> 2.34.1

--
epost|xmpp: nicolas@xxxxxxxxx irc://oftc.net/nsc
↳ gpg: 18ed 52db e34f 860e e9fb c82b 7d97 0932 55a0 ce7f
-- frykten for herren er opphav til kunnskap --