Re: [PATCH] arm64: dts: fix drive strength macros as per FSD HW UM

[Krzysztof Kozlowski]

On 10/10/2022 08:04, Padmanabhan Rajanbabu wrote:
> In FSD pinctrl implementation, the pinctrl driver is using drive strength
> MACROs, which are deviating from the actual values specified in FSD HW UM

But you are changing DTS, not pinctrl driver. The message is a bit
confusing.

Add full stop to the sentence.

> 
> This patch adds the right pinctrl drive strength values for FSD SoC. This

Do not use "This commit/patch".
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

> patch also ensures that the peripherals are using right drive strength
> MACROs in-order to function as expected

Full stop

Which commit introduced it? Add a Fixes tag.


> 
> Signed-off-by: Padmanabhan Rajanbabu <p.rajanbabu@xxxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi | 34 +++++++++++-----------
>  arch/arm64/boot/dts/tesla/fsd-pinctrl.h    |  6 ++--
>  2 files changed, 20 insertions(+), 20 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
> index d0abb9aa0e9e..e3852c946352 100644
> --- a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
> +++ b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
> @@ -55,14 +55,14 @@
>  		samsung,pins = "gpf5-0";
>  		samsung,pin-function = <FSD_PIN_FUNC_2>;
>  		samsung,pin-pud = <FSD_PIN_PULL_NONE>;
> -		samsung,pin-drv = <FSD_PIN_DRV_LV2>;
> +		samsung,pin-drv = <FSD_PIN_DRV_LV4>;

Are you sure? The original commit used here value of "2", your change
also set value of "2", so what deviates from actual values?

You need to describe better the problem.

Best regards,
Krzysztof