Re: [PATCH v4 1/2] dt-bindings: apple,aic: Document A7-A11 compatibles

From: Rob Herring
Date: Mon Oct 10 2022 - 08:27:34 EST


On Fri, Oct 07, 2022 at 10:00:21PM +0200, Konrad Dybcio wrote:
> Document the compatibles for Apple A7-A11 SoCs.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxx>
> ---
> Changes since v3:
> - Bindings: A7-A10+M1 only get SoC compat and generic fallback,
> A11 gets M1 fallback and generic fallback (removed A11 compatible)

I have no idea if that makes sense or not. Do I have to go read the
rationale in the prior version?

The question to ask on fallbacks, is would s/w that only understands the
fallback compatible work as-is?

> - Drop Rob's A-b as this is essentially yet another rewrite..
>
> .../bindings/interrupt-controller/apple,aic.yaml | 16 +++++++++++++---
> 1 file changed, 13 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml b/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml
> index e18107eafe7c..1427ea9b04a2 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml
> @@ -36,9 +36,19 @@ allOf:
>
> properties:
> compatible:
> - items:
> - - const: apple,t8103-aic
> - - const: apple,aic
> + oneOf:
> + - items:
> + - enum:
> + - apple,s5l8960x-aic
> + - apple,s8000-aic
> + - apple,t7000-aic
> + - apple,t8010-aic
> + - apple,t8103-aic
> + - const: apple,aic
> + - items:
> + - const: apple,t8015-aic
> + - const: apple,t8103-aic
> + - const: apple,aic
>
> interrupt-controller: true
>
> --
> 2.37.3
>
>