Re: [PATCH RESEND v5 1/1] clk: mstar: msc313 cpupll clk driver
From: Willy Tarreau
Date: Fri Sep 30 2022 - 15:37:09 EST
Hi Stephen,
On Fri, Sep 30, 2022 at 12:17:40PM -0700, Stephen Boyd wrote:
> Quoting Romain Perier (2022-06-03 12:05:09)
> > From: Daniel Palmer <daniel@xxxxxxxx>
> >
> > Add a driver for the CPU pll/ARM pll/MIPS pll that is present
> > in MStar SoCs.
> >
> > Currently there is no documentation for this block so it's possible
> > this driver isn't entirely correct.
> >
> > Only tested on the version of this IP in the MStar/SigmaStar
> > ARMv7 SoCs.
> >
> > Co-authored-by: Willy Tarreau <w@xxxxxx>
>
> This is not a standard tag, maybe Co-developed-by is what you want?
Yeah it's the same. We're seeing 122 co-authored-by tags in the
kernel's history vs 3122 co-developed-by, so that's only 3% but
at least not a fantasist one..
> A Signed-off-by tag should be here from Willy Tarreau then.
Not all commits follow this, but indeed some do. Regardless I
really don't care at all about my name being listed there.
> > Signed-off-by: Daniel Palmer <daniel@xxxxxxxx>
>
> Your Signed-off-by needs to be here. I can't apply this otherwise.
Quite frankly, we're talking about an old patch that was first
submitted 9 months ago (!), let's not postpone it even further just
for headers reason, please just drop this line mentioning my
little contribution, I don't care a single second at all, really.
Thanks,
Willy