Re: [PATCH v2 2/2] Documentation/process: Add text to indicate supporters should be mailed

[Bryan O'Donoghue]

On 29/09/2022 08:29, Krzysztof Kozlowski wrote:
> On 29/09/2022 02:25, Bryan O'Donoghue wrote:
> > Recently when submitting a yaml change I found that I had omitted the
> > maintainer whose tree the change needed to go through.
> >
> > The reason for that is the path in MAINTAINERS is marked as Supported not
> > Maintained. Reading MAINTAINERS we see quote:
> >
> >             Supported:   Someone is actually paid to look after this.
> >             Maintained:  Someone actually looks after it.
> >
> > The current submitting-patches.rst only says to mail maintainers though not
> > supporters. When we run scripts/get_maintainer.pl anybody who is denoted a
> > paid maintainer will appear as a supporter.
> >
> > Let's add some text to the submitting-patches.rst to indicate that
> > supporters should similarly be mailed so that you can't do as I did and
> > mail every maintainer get_maintainer.pl tells you to, without actually
> > mailing the one supporter you need to.
> >
> > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> > ---
> >   Documentation/process/submitting-patches.rst | 8 +++++---
> >   1 file changed, 5 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst
> > index be49d8f2601b4..aabccaea93375 100644
> > --- a/Documentation/process/submitting-patches.rst
> > +++ b/Documentation/process/submitting-patches.rst
> > @@ -227,9 +227,11 @@ You should always copy the appropriate subsystem maintainer(s) on any patch
> >   to code that they maintain; look through the MAINTAINERS file and the
> >   source code revision history to see who those maintainers are.  The
> >   script scripts/get_maintainer.pl can be very useful at this step (pass paths to
> > -your patches as arguments to scripts/get_maintainer.pl).  If you cannot find a
> > -maintainer for the subsystem you are working on, Andrew Morton
> > -(akpm@xxxxxxxxxxxxxxxxxxxx) serves as a maintainer of last resort.
> > +your patches as arguments to scripts/get_maintainer.pl).  You should mail
> > +everyone who appears as "maintainer[volunteer]" or "maintainer[supporter]" as
>
> As I said before, this still ignores reviewers. I don't think it is
> going to good direction. The submitter is expected to CC
> everyone/everything which is pointed by get_maintainers.pl except the
> Git-fallback entries.


I just found the --nogit-fallback option which produces:

scripts/get_maintainer.pl Documentation/process/submitting-patches.rst
Jonathan Corbet <corbet@xxxxxxx> 
(maintainer:DOCUMENTATION,commit_signer:10/12=83%)
Konstantin Ryabitsev <konstantin@xxxxxxxxxxxxxxxxxxx> 
(commit_signer:2/12=17%)
Thorsten Leemhuis <linux@xxxxxxxxxxxxx> 
(commit_signer:2/12=17%,authored:2/12=17%,added_lines:24/46=52%,removed_lines:13/67=19%)
Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> 
(commit_signer:2/12=17%,authored:2/12=17%,added_lines:8/46=17%,removed_lines:4/67=6%)
Randy Dunlap <rdunlap@xxxxxxxxxxxxx> (commit_signer:2/12=17%)
"Bryan O'Donoghue" <bryan.odonoghue@xxxxxxxxxx> 
(authored:1/12=8%,added_lines:5/46=11%)
Erik Ekman <erik@xxxxxxx> (authored:1/12=8%)
Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> (authored:1/12=8%)
Jiri Kosina <jkosina@xxxxxxx> (removed_lines:20/67=30%)
Miguel Ojeda <ojeda@xxxxxxxxxx> (removed_lines:19/67=28%)
linux-doc@xxxxxxxxxxxxxxx (open list:DOCUMENTATION)
linux-kernel@xxxxxxxxxxxxxxx (open list)

scripts/get_maintainer.pl --status --nom --nol --nogit --nogit-fallback 
-f Documentation/process/submitting-patches.rst

How about something like "send email to every mail address produced by 
scripts/get_maintainer.pl $filename but consider linux-kernel optional 
when sending subsystem specific patches"

---
bod