Re: [PATCH 1/4] tty: serial: extend lqasc_tx_ready() to lqasc_console_putchar()

[Ilpo Järvinen]

On Tue, 27 Sep 2022, Jiri Slaby wrote:

> There is one more place where lqasc_tx_ready() can be used now:
> lqasc_console_putchar(). So replace the open-coded variant by the
> helper.
> 
> Suggested-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>

> ---
>  drivers/tty/serial/lantiq.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/tty/serial/lantiq.c b/drivers/tty/serial/lantiq.c
> index 6da1b7496c6c..ba9739af30ed 100644
> --- a/drivers/tty/serial/lantiq.c
> +++ b/drivers/tty/serial/lantiq.c
> @@ -606,15 +606,12 @@ static const struct uart_ops lqasc_pops = {
>  static void
>  lqasc_console_putchar(struct uart_port *port, unsigned char ch)
>  {
> -	int fifofree;
> -
>  	if (!port->membase)
>  		return;
>  
> -	do {
> -		fifofree = (__raw_readl(port->membase + LTQ_ASC_FSTAT)
> -			& ASCFSTAT_TXFREEMASK) >> ASCFSTAT_TXFREEOFF;
> -	} while (fifofree == 0);
> +	while (!lqasc_tx_ready(port))
> +		;
> +
>  	writeb(ch, port->membase + LTQ_ASC_TBUF);
>  }
>  
>