Re: [PATCH] mm: fix misuse of update_mmu_cache() in do_anonymous_page()

From: Muchun Song
Date: Sat Sep 24 2022 - 21:44:09 EST




> On Sep 24, 2022, at 13:32, Qi Zheng <zhengqi.arch@xxxxxxxxxxxxx> wrote:
>
> As message in commit 7df676974359 ("mm/memory.c: Update local TLB
> if PTE entry exists") said, we should update local TLB only on the
> second thread. So fix the misuse of update_mmu_cache() by using
> update_mmu_tlb() in the do_anonymous_page().
>
> Signed-off-by: Qi Zheng <zhengqi.arch@xxxxxxxxxxxxx>

The change looks good to me. However, I am not sure what is the user-visible
effect to xtensa users. So Cc xtensa’s maintainer and the author of 7df676974359
to double check this.


But anyway:

Reviewed-by: Muchun Song <songmuchun@xxxxxxxxxxxxx>