Re: [PATCH v5 08/10] livepatch: Improve the search performance of module_kallsyms_on_each_symbol()

[Leizhen (ThunderTown)]

On 2022/9/24 9:11, Leizhen (ThunderTown) wrote:
> 
> On 2022/9/23 19:20, Zhen Lei wrote:
>> Currently we traverse all symbols of all modules to find the specified
>> function for the specified module. But in reality, we just need to find
>> the given module and then traverse all the symbols in it.
>>
>> In order to achieve this purpose, split the call to hook 'fn' into two
>> phases:
>> 1. Finds the given module. Pass pointer 'mod'. Hook 'fn' directly returns
>>    the comparison result of the module name without comparing the function
>>    name.
>> 2. Finds the given function in that module. Pass pointer 'mod = NULL'.
>>    Hook 'fn' skip the comparison of module name and directly compare
>>    function names.
> Sorry, I forgot to change the description. I will fix it in v6, after I've
> collected review comments.

Oh, It's Saturday, and I don't think anyone's seen v5 yet. So I'll post the v6.
Please skip v5.

> 

-- 
Regards,
  Zhen Lei