Re: [PATCH -next] scsi: qla2xxx: Fix build error implicit-function-declaration

[Ren Zhijie]

在 2022/9/19 15:17, Daniel Wagner 写道:
> On Mon, Sep 19, 2022 at 11:08:10AM +0800, Ren Zhijie wrote:
> > +#ifdef CONFIG_TRACING
> >   static void
> >   qla_trace_init(void)
> >   {
> > @@ -2868,7 +2871,7 @@ qla_trace_uninit(void)
> >   		return;
> >   	trace_array_put(qla_trc_array);
> >   }
> > -
> > +#endif
> FWIW, the qla2xxx driver uses a different pattern for ifdefs
>
> 	static void
> 	qla_trace_init(void)
> 	{
> 	#ifdef CONFIG_TRACING
> 	[...]
>          #endif
>          }
>
> This avoid to updated the callside with ifdefs.

Thanks, I will send patch v2.

Ren

> .
.