Re: [PATCH] dmaengine: qcom-adm: fix wrong sizeof config in slave_config

From: Dmitry Baryshkov
Date: Thu Sep 15 2022 - 17:56:43 EST


On Thu, 15 Sept 2022 at 23:49, Christian Marangi <ansuelsmth@xxxxxxxxx> wrote:
>
> Fix broken slave_config function that uncorrectly compare the
> peripheral_size with the size of the config pointer instead of the size
> of the config struct. This cause the crci value to be ignored and cause
> a kernel panic on any slave that use adm driver.
>
> To fix this, compare to the size of the struct and NOT the size of the
> pointer.
>
> Fixes: 03de6b273805 ("dmaengine: qcom-adm: stop abusing slave_id config")
> Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx # v5.17+

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>

> ---
> drivers/dma/qcom/qcom_adm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)


--
With best wishes
Dmitry