Re: [PATCH] fat: device-level-flush-after-sync

From: kernel test robot
Date: Thu Sep 15 2022 - 09:01:16 EST


Hi Gianfranco,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.0-rc5 next-20220915]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Gianfranco/fat-device-level-flush-after-sync/20220915-014337
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 3245cb65fd91cd514801bf91f5a3066d562f0ac4
config: x86_64-randconfig-a011 (https://download.01.org/0day-ci/archive/20220915/202209152048.xURrWxEC-lkp@xxxxxxxxx/config)
compiler: gcc-11 (Debian 11.3.0-5) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/b1130c74311f7b8c0713f373a8dc20b572883fca
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Gianfranco/fat-device-level-flush-after-sync/20220915-014337
git checkout b1130c74311f7b8c0713f373a8dc20b572883fca
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash fs/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

fs/fat/inode.c: In function 'fat_sync_fs':
>> fs/fat/inode.c:829:24: error: too many arguments to function 'blkdev_issue_flush'
829 | return blkdev_issue_flush(sb->s_bdev, GFP_KERNEL, NULL);
| ^~~~~~~~~~~~~~~~~~
In file included from fs/fat/inode.c:21:
include/linux/blkdev.h:1031:5: note: declared here
1031 | int blkdev_issue_flush(struct block_device *bdev);
| ^~~~~~~~~~~~~~~~~~


vim +/blkdev_issue_flush +829 fs/fat/inode.c

825
826 static int fat_sync_fs(struct super_block *sb, int wait)
827 {
828 if (wait)
> 829 return blkdev_issue_flush(sb->s_bdev, GFP_KERNEL, NULL);
830 else
831 return 0;
832 }
833

--
0-DAY CI Kernel Test Service
https://01.org/lkp