Re: [PATCH v2 07/13] i2c: acpi: Use ACPI wake capability bit to set wake_irq

From: Andy Shevchenko
Date: Wed Sep 14 2022 - 05:43:00 EST


On Tue, Sep 13, 2022 at 12:56:37PM -0600, Raul Rangel wrote:
> On Tue, Sep 13, 2022 at 12:33 PM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > On Tue, Sep 13, 2022 at 12:07:53PM -0600, Raul Rangel wrote:

...

> > This is similar to what of_i2c_get_board_info() does, no?
> > Note: _get_ there.
>
> `*info` is an out parameter in that case. Ideally I would have
> `i2c_acpi_get_irq`, `acpi_dev_gpio_irq_get_wake`,
> `platform_get_irq_optional`, and `i2c_dev_irq_from_resources` all
> return a `struct irq_info {int irq; bool wake_capable;}`. This would
> be a larger change though.

Seems the ACPI analogue is i2c_acpi_fill_info(). Can we do it there?

--
With Best Regards,
Andy Shevchenko