Re: [PATCH 2/2] USB: serial: option: add support for docomo L-03F

[Chris Packham]

On 14/09/22 16:10, Lars Melin wrote:
> On 9/14/2022 09:55, Chris Packham wrote:
>> Add support for the docomo L-03F modem.
>>
>> Signed-off-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx>
>> ---
>>   drivers/usb/serial/option.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
>> index 2065f0fb2fa0..14eaff50820b 100644
>> --- a/drivers/usb/serial/option.c
>> +++ b/drivers/usb/serial/option.c
>> @@ -527,6 +527,7 @@ static void option_instat_callback(struct urb *urb);
>>   /* LG products */
>>   #define LG_VENDOR_ID                0x1004
>>   #define LG_PRODUCT_L02C                0x618f
>> +#define LG_PRODUCT_L03F                0x6366
>>     /* MediaTek products */
>>   #define MEDIATEK_VENDOR_ID            0x0e8d
>> @@ -2079,6 +2080,7 @@ static const struct usb_device_id option_ids[] = {
>>       { USB_DEVICE_AND_INTERFACE_INFO(VIETTEL_VENDOR_ID, 
>> VIETTEL_PRODUCT_VT1000, 0xff, 0xff, 0xff) },
>>       { USB_DEVICE_AND_INTERFACE_INFO(ZD_VENDOR_ID, ZD_PRODUCT_7000, 
>> 0xff, 0xff, 0xff) },
>>       { USB_DEVICE(LG_VENDOR_ID, LG_PRODUCT_L02C) }, /* docomo L-02C 
>> modem */
>> +    { USB_DEVICE(LG_VENDOR_ID, LG_PRODUCT_L03F) }, /* docomo L-03F 
>> modem */
>>       { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a1, 
>> 0xff, 0x00, 0x00) },
>>       { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a1, 
>> 0xff, 0x02, 0x01) },
>>       { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a2, 
>> 0xff, 0x00, 0x00) },
>
>
> Hi,
> this doesn't seem to be correct. Since this is a LTE CAT3 highspeed 
> device and the modem manual mentions MS Win NDIS driver then one 
> interface is likely to be a QMI interface which you must blacklist in 
> the option driver.
> Please provide a usb-devices or verbose lsusb output for the modem.

Yamamoto-san, are you able to provide the lsusb -v output for this 
device? (Our internal issue for the code change is CR-56120).

>
> thanks
> Lars