Re: [PATCH] interconnect: qcom: Add the missing MODULE_LICENSE

[Huang Yiwei]

Hi Leo,

On 9/13/2022 Tue 15:08, Leo Yan wrote:
> Hi Yiwei,
>
> On Tue, Sep 13, 2022 at 02:27:21PM +0800, Huang Yiwei wrote:
> > Since icc-common.c can be compiled as module, add the missing
> > MODULE_LICENSE to avoid compile errors.
>
> Just curious how you can enable config INTERCONNECT_QCOM as "m"
> (module)?
>
> I checked the config INTERCONNECT_QCOM which is dependent on
> INTERCONNECT, and INTERCONNECT has below dependency:
>
>    - DRM_TEGRA [=n] && HAS_IOMEM [=y] && (ARCH_TEGRA [=y] || ARM && COMPILE_TEST [=n]) && COMMON_CLK [=y] && DRM [=m] && OF [=y]
>    - TEGRA_MC [=n] && MEMORY [=y] && (ARCH_TEGRA [=y] || COMPILE_TEST [=n] && COMMON_CLK [=y])
>
> Seems to me, it's impossible to enable INTERCONNECT as "m" because the
> dependency ARCH_TEGRA/OF/COMMON_CLK cannot be configured as "m".
>
> Thanks,
> Leo
Found the problem, INTERCONNECT_QCOM is modified to tristate internally
so we can compile it as a module, and the new added icc-common.c uses
INTERCONNECT_QCOM config to compile, then cause the problem. So shall we
change INTERCONNECT_QCOM config to tristate?

Thanks,
Yiwei