Re: [PATCH 4/4] Bluetooth: btusb: mediatek: add MediaTek devcoredump support
From: kernel test robot
Date: Tue Sep 13 2022 - 02:30:02 EST
Hi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on bluetooth/master]
[also build test ERROR on bluetooth-next/master linus/master v6.0-rc5 next-20220912]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/sean-wang-mediatek-com/Bluetooth-btusb-mediatek-use-readx_poll_timeout-instead-of-open-coding/20220913-062200
base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git master
config: arc-randconfig-r043-20220912 (https://download.01.org/0day-ci/archive/20220913/202209131404.9rjV6blJ-lkp@xxxxxxxxx/config)
compiler: arc-elf-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/d478461e2fd5fdd8d505c00c7864a421170a54bb
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review sean-wang-mediatek-com/Bluetooth-btusb-mediatek-use-readx_poll_timeout-instead-of-open-coding/20220913-062200
git checkout d478461e2fd5fdd8d505c00c7864a421170a54bb
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash drivers/bluetooth/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All errors (new ones prefixed by >>):
drivers/bluetooth/btmtk.c: In function 'btmtk_coredump_notify':
>> drivers/bluetooth/btmtk.c:111:14: error: 'HCI_DEVCOREDUMP_ACTIVE' undeclared (first use in this function); did you mean 'BTMTK_COREDUMP_ACTIVE'?
111 | case HCI_DEVCOREDUMP_ACTIVE:
| ^~~~~~~~~~~~~~~~~~~~~~
| BTMTK_COREDUMP_ACTIVE
drivers/bluetooth/btmtk.c:111:14: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/bluetooth/btmtk.c:114:14: error: 'HCI_DEVCOREDUMP_TIMEOUT' undeclared (first use in this function); did you mean 'HCI_LE_CONN_TIMEOUT'?
114 | case HCI_DEVCOREDUMP_TIMEOUT:
| ^~~~~~~~~~~~~~~~~~~~~~~
| HCI_LE_CONN_TIMEOUT
>> drivers/bluetooth/btmtk.c:115:14: error: 'HCI_DEVCOREDUMP_ABORT' undeclared (first use in this function)
115 | case HCI_DEVCOREDUMP_ABORT:
| ^~~~~~~~~~~~~~~~~~~~~
>> drivers/bluetooth/btmtk.c:116:14: error: 'HCI_DEVCOREDUMP_DONE' undeclared (first use in this function)
116 | case HCI_DEVCOREDUMP_DONE:
| ^~~~~~~~~~~~~~~~~~~~
drivers/bluetooth/btmtk.c: In function 'btmtk_register_coredump':
>> drivers/bluetooth/btmtk.c:376:9: error: implicit declaration of function 'hci_devcoredump_register' [-Werror=implicit-function-declaration]
376 | hci_devcoredump_register(hdev, btmtk_coredump, btmtk_coredump_hdr,
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/bluetooth/btmtk.c: In function 'btmtk_process_coredump':
>> drivers/bluetooth/btmtk.c:393:23: error: implicit declaration of function 'hci_devcoredump_init' [-Werror=implicit-function-declaration]
393 | err = hci_devcoredump_init(hdev, 1024000);
| ^~~~~~~~~~~~~~~~~~~~
>> drivers/bluetooth/btmtk.c:397:44: error: 'struct hci_dev' has no member named 'dump'
397 | schedule_delayed_work(&hdev->dump.dump_timeout,
| ^~
>> drivers/bluetooth/btmtk.c:402:23: error: implicit declaration of function 'hci_devcoredump_append' [-Werror=implicit-function-declaration]
402 | err = hci_devcoredump_append(hdev, skb);
| ^~~~~~~~~~~~~~~~~~~~~~
>> drivers/bluetooth/btmtk.c:409:25: error: implicit declaration of function 'hci_devcoredump_complete' [-Werror=implicit-function-declaration]
409 | hci_devcoredump_complete(hdev);
| ^~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +111 drivers/bluetooth/btmtk.c
107
108 static void btmtk_coredump_notify(struct hci_dev *hdev, int state)
109 {
110 switch (state) {
> 111 case HCI_DEVCOREDUMP_ACTIVE:
112 coredump_info.state = BTMTK_COREDUMP_ACTIVE;
113 break;
> 114 case HCI_DEVCOREDUMP_TIMEOUT:
> 115 case HCI_DEVCOREDUMP_ABORT:
> 116 case HCI_DEVCOREDUMP_DONE:
117 coredump_info.state = BTMTK_COREDUMP_INIT;
118 btmtk_reset_sync(coredump_info.hdev);
119 break;
120 }
121 }
122
--
0-DAY CI Kernel Test Service
https://01.org/lkp