Re: [PATCH 3/5] ACPI: battery: Allow battery hooks to be registered multiple times.

From: Armin Wolf
Date: Mon Sep 12 2022 - 13:30:07 EST


Am 12.09.22 um 18:42 schrieb Barnabás Pőcze:

Hi

2022. szeptember 12., hétfő 14:53 keltezéssel, Armin Wolf írta:

Registering multiple instances of a battery hook is beneficial
for drivers which can be instantiated multiple times. Until now,
this would mean that such a driver would have to implement some
logic to manage battery hooks.

Extend the battery hook handling instead.
I think this is already possible by embedding the acpi_battery_hook
object inside the driver's device specific data object, no?

Regards,
Barnabás Pőcze


Yes, it indeed is. However afaik it is not possible to pass instance-specific
data to such an embedded battery hook. It could be possible by passing the
battery hook as an argument to add_battery()/remove_battery() and using container_of(),
but in my opinion this would be too much of a quick hack.

[...]