Re: [PATCH] iio: ltc2497: Fix reading conversion results

From: Uwe Kleine-König
Date: Mon Sep 12 2022 - 06:47:07 EST


On Sat, Aug 20, 2022 at 01:06:48PM +0100, Jonathan Cameron wrote:
> On Mon, 15 Aug 2022 09:16:47 +0000
> Denys Zagorui <dzagorui@xxxxxxxxx> wrote:
>
> > From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> >
> > After the result of the previous conversion is read the chip
> > automatically starts a new conversion and doesn't accept new i2c
> > transfers until this conversion is completed which makes the function
> > return failure.
>
> That's rather nasty.
>
> Could we add a cheeky sleep in the other path to ensure there is always
> time for the conversion to be done? Not ideal, but might ensure
> there isn't a known problem path without introducing much complexity.

FTR: While the patch was originally authored by me, I don't currently
have access to a machine with that chip. So currently there will be no
incentive on my side to address this feedback.

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature