Re: [PATCH] mm/damon/sysfs: change few functions execute order

From: SeongJae Park
Date: Fri Sep 09 2022 - 19:00:33 EST


On Fri, 9 Sep 2022 15:44:34 -0700 Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Thu, 8 Sep 2022 22:16:53 +0000 SeongJae Park <sj@xxxxxxxxxx> wrote:
>
> > Reviewed-by: SeongJae Park <sj@xxxxxxxxxx>
>
> Cool. I rewrote the changelog significantly:
>
> From: Xin Hao <xhao@xxxxxxxxxxxxxxxxx>
> Subject: mm/damon/sysfs: change few functions execute order
> Date: Thu, 8 Sep 2022 16:19:32 +0800
>
> There's no need to run container_of() as early as we do.
>
> The compiler figures this out, but the resulting code is more readable.

Looks very nice to me. Thank you, Andrew!


Thanks,
SJ

[...]