Re: [PATCH linux-next] drm/amdgpu: Remove the unneeded result variable

From: Alex Deucher
Date: Fri Sep 09 2022 - 16:47:56 EST


Applied. Thanks!

Alex

On Fri, Sep 2, 2022 at 4:04 AM <cgel.zte@xxxxxxxxx> wrote:
>
> From: zhang songyi <zhang.songyi@xxxxxxxxxx>
>
> Return the sdma_v6_0_start() directly instead of storing it in another
> redundant variable.
>
> Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> Signed-off-by: zhang songyi <zhang.songyi@xxxxxxxxxx>
> ---
> drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c
> index 2bc1407e885e..2cc2d851b4eb 100644
> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c
> @@ -1373,12 +1373,9 @@ static int sdma_v6_0_sw_fini(void *handle)
>
> static int sdma_v6_0_hw_init(void *handle)
> {
> - int r;
> struct amdgpu_device *adev = (struct amdgpu_device *)handle;
>
> - r = sdma_v6_0_start(adev);
> -
> - return r;
> + return sdma_v6_0_start(adev);
> }
>
> static int sdma_v6_0_hw_fini(void *handle)
> --
> 2.25.1
>
>