Re: [PATCH] thermal: rcar_thermal: Constify static thermal_zone_device_ops

[Niklas Söderlund]

Hi Lad,

Thanks for your work.

On 2022-09-09 19:28:38 +0100, Lad Prabhakar wrote:
> The only usage of rcar_thermal_zone_of_ops is to pass its address to
> devm_thermal_of_zone_register(), which takes a pointer to const struct
> thermal_zone_device_ops. Make it const to allow the compiler to put
> it in read-only memory.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>

> ---
>  drivers/thermal/rcar_thermal.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c
> index 4df42d70d867..61c2b8855cb8 100644
> --- a/drivers/thermal/rcar_thermal.c
> +++ b/drivers/thermal/rcar_thermal.c
> @@ -316,7 +316,7 @@ static int rcar_thermal_get_trip_temp(struct thermal_zone_device *zone,
>  	return 0;
>  }
>  
> -static struct thermal_zone_device_ops rcar_thermal_zone_of_ops = {
> +static const struct thermal_zone_device_ops rcar_thermal_zone_of_ops = {
>  	.get_temp	= rcar_thermal_get_temp,
>  };
>  
> -- 
> 2.25.1
> 

-- 
Kind Regards,
Niklas Söderlund