Re: [PATCH v3 8/8] sched/fair: Add latency list

From: kernel test robot
Date: Fri Sep 09 2022 - 12:08:57 EST


Hi Vincent,

I love your patch! Perhaps something to improve:

[auto build test WARNING on tip/sched/core]
[also build test WARNING on linus/master v6.0-rc4 next-20220909]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Vincent-Guittot/Add-latency-priority-for-CFS-class/20220909-210655
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git fb04563d1cae6f361892b4a339ad92100b1eb0d0
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20220909/202209092349.DjjxV7GB-lkp@xxxxxxxxx/config)
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/4bdc6637b9aab44577b65686a745a14b325f4c23
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Vincent-Guittot/Add-latency-priority-for-CFS-class/20220909-210655
git checkout 4bdc6637b9aab44577b65686a745a14b325f4c23
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash kernel/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> kernel/sched/fair.c:727:22: warning: no previous prototype for '__pick_first_latency' [-Wmissing-prototypes]
727 | struct sched_entity *__pick_first_latency(struct cfs_rq *cfs_rq)
| ^~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:742:5: warning: no previous prototype for 'sched_update_scaling' [-Wmissing-prototypes]
742 | int sched_update_scaling(void)
| ^~~~~~~~~~~~~~~~~~~~


vim +/__pick_first_latency +727 kernel/sched/fair.c

726
> 727 struct sched_entity *__pick_first_latency(struct cfs_rq *cfs_rq)
728 {
729 struct rb_node *left = rb_first_cached(&cfs_rq->latency_timeline);
730
731 if (!left)
732 return NULL;
733
734 return __latency_node_2_se(left);
735 }
736

--
0-DAY CI Kernel Test Service
https://01.org/lkp