Re: [PATCH v2] drm: omapdrm: Improve check for contiguous buffers

From: Tomi Valkeinen
Date: Fri Sep 09 2022 - 09:09:01 EST


On 25/08/2022 19:26, Andrew Davis wrote:
While a scatter-gather table having only 1 entry does imply it is
contiguous, it is a logic error to assume the inverse. Tables can have
more than 1 entry and still be contiguous. Use a proper check here.

Signed-off-by: Andrew Davis <afd@xxxxxx>
---

Changes from v1:
- Sent correct version of patch :)

Looks fine to me. But where do you need this? Are contiguous buffers with multiple sgt entries handled correctly elsewhere in the driver, i.e. do they work? =)

Tomi