Re: [PATCH AUTOSEL 5.19 01/33] firmware: dmi: Use the proper accessor for the version field

[Sasha Levin]

On Wed, Aug 31, 2022 at 02:50:25PM +0300, Andy Shevchenko wrote:
> On Tue, Aug 30, 2022 at 11:32:37PM +0200, Jean Delvare wrote:
> > On Tue, 30 Aug 2022 13:17:52 -0400, Sasha Levin wrote:
> > > From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > >
> > > [ Upstream commit d2139dfca361a1f5bfc4d4a23455b1a409a69cd4 ]
> > >
> > > The byte at offset 6 represents length. Don't take it and drop it
> > > immediately by using proper accessor, i.e. get_unaligned_be24().
> > >
> > > [JD: Change the subject to something less frightening]
> >
> > Nack. This is NOT a bug fix, there's simply no reason to backport
> > this to stable kernel trees.
>
> Agree.

I'll drop it, thanks.

--
Thanks,
Sasha