Re: [RFC PATCH 09/26] hugetlb: add hugetlb_hgm_enabled

From: James Houghton
Date: Thu Sep 08 2022 - 14:14:16 EST


On Thu, Sep 8, 2022 at 11:07 AM Peter Xu <peterx@xxxxxxxxxx> wrote:
>
> On Fri, Jun 24, 2022 at 05:36:39PM +0000, James Houghton wrote:
> > +#ifdef CONFIG_HUGETLB_HIGH_GRANULARITY_MAPPING
> > +bool hugetlb_hgm_enabled(struct vm_area_struct *vma)
> > +{
> > + /* All shared VMAs have HGM enabled. */
> > + return vma->vm_flags & VM_SHARED;
> > +}
> > +#endif /* CONFIG_HUGETLB_HIGH_GRANULARITY_MAPPING */
>
> Another nitpick: suggest to rename this to "hugetlb_***_supported()" (with
> whatever the new name could be..), as long as it cannot be "disabled". :)
>

Will do. :)

- James

> --
> Peter Xu
>