Re: [PATCH v4 13/13] Documentation/x86: Update resctrl_ui.rst for new features

From: Moger, Babu
Date: Thu Sep 08 2022 - 09:41:15 EST



On 9/8/22 04:26, Bagas Sanjaya wrote:
> On Thu, Sep 08, 2022 at 11:07:59AM +0700, Bagas Sanjaya wrote:
>> Use code blocks for terminal output above:
>>
>> ---- >8 ----
>> t a/Documentation/x86/resctrl.rst b/Documentation/x86/resctrl.rst
>> index 56581587c1a331..6474cf655792bf 100644
>> --- a/Documentation/x86/resctrl.rst
>> +++ b/Documentation/x86/resctrl.rst
>> @@ -163,23 +163,23 @@ with the following files:
>> "mon_features":
>> Lists the monitoring events if
>> monitoring is enabled for the resource.
>> - Example output:
>> + Example::
>>
>> - # cat /sys/fs/resctrl/info/L3_MON/mon_features
>> - llc_occupancy
>> - mbm_total_bytes
>> - mbm_local_bytes
>> + # cat /sys/fs/resctrl/info/L3_MON/mon_features
>> + llc_occupancy
>> + mbm_total_bytes
>> + mbm_local_bytes
>>
>> If the system supports Bandwidth Monitoring Event
>> Configuration (BMEC), then the bandwidth events will
>> - be configurable. Then the output will be.
>> + be configurable. The output will be::
>>
>> - # cat /sys/fs/resctrl/info/L3_MON/mon_features
>> - llc_occupancy
>> - mbm_total_bytes
>> - mbm_total_config
>> - mbm_local_bytes
>> - mbm_local_config
>> + # cat /sys/fs/resctrl/info/L3_MON/mon_features
>> + llc_occupancy
>> + mbm_total_bytes
>> + mbm_total_config
>> + mbm_local_bytes
>> + mbm_local_config
> Hi Babu,
>
> The suggestion diff above looks corrupted, so here is the proper one:

Sanjaya,

Sure, Thank you.

Babu

>
> ---- >8 ----
> diff --git a/Documentation/x86/resctrl.rst b/Documentation/x86/resctrl.rst
> index 56581587c1a331..6474cf655792bf 100644
> --- a/Documentation/x86/resctrl.rst
> +++ b/Documentation/x86/resctrl.rst
> @@ -163,23 +163,23 @@ with the following files:
> "mon_features":
> Lists the monitoring events if
> monitoring is enabled for the resource.
> - Example output:
> + Example::
>
> - # cat /sys/fs/resctrl/info/L3_MON/mon_features
> - llc_occupancy
> - mbm_total_bytes
> - mbm_local_bytes
> + # cat /sys/fs/resctrl/info/L3_MON/mon_features
> + llc_occupancy
> + mbm_total_bytes
> + mbm_local_bytes
>
> If the system supports Bandwidth Monitoring Event
> Configuration (BMEC), then the bandwidth events will
> - be configurable. Then the output will be.
> + be configurable. The output will be::
>
> - # cat /sys/fs/resctrl/info/L3_MON/mon_features
> - llc_occupancy
> - mbm_total_bytes
> - mbm_total_config
> - mbm_local_bytes
> - mbm_local_config
> + # cat /sys/fs/resctrl/info/L3_MON/mon_features
> + llc_occupancy
> + mbm_total_bytes
> + mbm_total_config
> + mbm_local_bytes
> + mbm_local_config
>
> "max_threshold_occupancy":
> Read/write file provides the largest value (in
>
> Thanks.
>
--
Thanks
Babu Moger