Re: [PATCH] m68k/mac: fix repeated words in comments

From: Geert Uytterhoeven
Date: Thu Sep 08 2022 - 09:16:36 EST


Hi Wangjianli,

On Thu, Sep 8, 2022 at 2:57 PM wangjianli <wangjianli@xxxxxxxxxx> wrote:
> Delete the redundant word 'in'.
>
> Signed-off-by: wangjianli <wangjianli@xxxxxxxxxx>

Thanks for your patch!

> --- a/arch/m68k/mac/misc.c
> +++ b/arch/m68k/mac/misc.c
> @@ -126,7 +126,7 @@ static void via_rtc_send(__u8 data)
>
> reg = via1[vBufB] & ~(VIA1B_vRTCClk | VIA1B_vRTCData);
>
> - /* The bits of the byte go in in MSB order */
> + /* The bits of the byte go in MSB order */
>
> for (i = 0 ; i < 8 ; i++) {
> bit = data & 0x80? 1 : 0;

The original is correct, cfr.
https://lore.kernel.org/linux-m68k/CAMuHMdVf7EOrXkUpa1E1Qx1w0Tvrt1nwRHM6B8rsGPOh=WsnyA@xxxxxxxxxxxxxx
https://lore.kernel.org/linux-m68k/CAMuHMdWwqKyvtxkvdng0EVFfKjz9iOjK3Dhfd+iru-j731azTw@xxxxxxxxxxxxxx

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds