Re: [PATCH] sbitmap: fix possible io hung due to lost wakeup

[Jan Kara]

On Wed 07-09-22 12:20:09, Keith Busch wrote:
> On Wed, Sep 07, 2022 at 06:41:50PM +0200, Jan Kara wrote:
> > On Wed 07-09-22 08:13:40, Keith Busch wrote:
> > > 
> > > I'm not sure about this part. We've already decremented, so the freed bit is
> > > accounted for against the batch. Returning true here may double-count the freed
> > > bit, right?
> > 
> > Yes, we may wake up waiters unnecessarily frequently. But that's a
> > performance issue at worst and only if it happens frequently. So I don't
> > think it matters in practice (famous last words ;).
> 
> Ok, let's go with that. Do you want to send the patch? I have a follow-up fix
> for batched tagging that depends on this.

I think Kuai will do that. But if not, I can certainly take his patch and
resubmit it with the fixup.

								Honza
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR