RE: [EXT] Re: [PATCH V4 3/4] ARM: dts: imx: update sdma node name format

From: Joy Zou
Date: Wed Aug 31 2022 - 22:13:56 EST



> -----Original Message-----
> From: Fabio Estevam <festevam@xxxxxxxxx>
> Sent: 2022年9月1日 10:10
> To: Joy Zou <joy.zou@xxxxxxx>
> Cc: robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx;
> shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx;
> dl-linux-imx <linux-imx@xxxxxxx>; devicetree@xxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [EXT] Re: [PATCH V4 3/4] ARM: dts: imx: update sdma node name
> format
>
> Caution: EXT Email
>
> Hi Joy.
>
> On Wed, Aug 31, 2022 at 11:02 PM Joy Zou <joy.zou@xxxxxxx> wrote:
> >
> > change the sdma node name format 'sdma' into 'dma-controller'.
>
> The changes looks good, but the commit log needs to be improved.
>
> Please explain the rationale for changing the name. Something like this:
>
> Node names should be generic, so change the node name from 'sdma' to
> 'dma-controller'.
>
Ok, I will modify the commit log in patch v5.
Thank you very much!
BR
Joy Zou
> Thanks