Re: [PATCH v3 08/19] dt-bindings: hwmon: (mr75203) add "moortec, vm-active-channels" property

[Farber, Eliav]

On 8/31/2022 10:19 PM, Rob Herring wrote:
> On Wed, Aug 31, 2022 at 12:48 PM Farber, Eliav <farbere@xxxxxxxxxx> 
> wrote:
> > On 8/31/2022 3:17 PM, Rob Herring wrote:
> > > On Wed, Aug 31, 2022 at 6:53 AM Farber, Eliav <farbere@xxxxxxxxxx> 
> > wrote:
> > >>
> > >> On 8/31/2022 2:39 PM, Rob Herring wrote:
> > >>
> > >> On Tue, 30 Aug 2022 19:22:01 +0000, Eliav Farber wrote:
> > >>
> > >> Add optional "moortec,vm-active-channels" property to define the 
> > number
> > >> of active channels per VM.
> > >>
> > >> This shall be useful to avoid exposing sysfs for reading inputs 
> > that are
> > >> not connected to any voltage source.
> > >>
> > >> Signed-off-by: Eliav Farber <farbere@xxxxxxxxxx>
> > >> ---
> > >> V3 -> V2:
> > >> - Add "moortec" prefix to property name.
> > >> - Add explanation why this change is needed.
> > >>
> > >>  .../devicetree/bindings/hwmon/moortec,mr75203.yaml | 11 +++++++++++
> > >>  1 file changed, 11 insertions(+)
> > >>
> > >>
> > >> My bot found errors running 'make DT_CHECKER_FLAGS=-m 
> > dt_binding_check'
> > >> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> > >>
> > >> I used dt_binding_check on my changes (I ported it to my kernel).
> > >> The error is related to "intel-vm-map" which I did not add.
> > >
> > > The error is the vendor prefix is not defined in vendor-prefixes.yaml.
> >
> > I fixed the vendor prefix error (will be part of v4).
> >
> > >> I don't mind fixing it if you wish.
> > >> It requires changing:
> > >>   intel,vm-map = [03 01 04 ff ff];
> > >> to:
> > >>   intel,vm-map = /bits/8 <0x03 0x01 0x04 0xff 0xff>;
> > >
> > > That is not the issue. The issue is the type is unknown because your
> > > schema fails and we can't get the type from it. Once your schema
> > > passes, this should go away.
> > Even after fixing the vendor prefix error I still see this:
> > moortec,mr75203.yaml: ignoring, error in schema: properties: 
> > intel,vm-map
>
> You still have an error in the schema. You should see a more specific
> reason before this message. 

Thanks, I found the problem.
I'm using an old version, and I'm missing this commit you did:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml?h=v6.0-rc3&id=d69c6ddd019f31081cc0232fa8ad8ea1cabdf22c