Re: [PATCH v4 4/6] mfd: drivers: Add TI TPS65219 PMIC support

From: Markus Schneider-Pargmann
Date: Wed Aug 31 2022 - 15:03:09 EST


Hi Krzysztof,

On Tue, Aug 30, 2022 at 12:46:53PM +0300, Krzysztof Kozlowski wrote:
> On 25/08/2022 18:02, Markus Schneider-Pargmann wrote:
> > From: Jerome Neanne <jneanne@xxxxxxxxxxxx>
> >
> > The TPS65219 is a power management IC PMIC designed to supply a wide
> > range of SoCs in both portable and stationary applications. Any SoC can
> > control TPS65219 over a standard I2C interface.
> >
> > It contains the following components:
> > - Regulators.
> > - Over Temperature warning and Shut down.
> > - GPIOs
> > - Multi Function Pins (MFP)
> > - power-button
> >
> > This patch adds support for tps65219 PMIC. At this time only
> > the functionalities listed below are made available:
> >
> > - Regulators probe and functionalities
> > - warm and cold reset support
> > - SW shutdown support
> > - Regulator warnings via IRQs
> > - Power-button via IRQ
> >
> > Signed-off-by: Jerome Neanne <jneanne@xxxxxxxxxxxx>
> > Signed-off-by: Markus Schneider-Pargmann <msp@xxxxxxxxxxxx>
> > ---
> >
> > Notes:
> > Changes in v4:
> > - Removed unused fields from struct tps65219
> > - Added description for the fields in struct tps65219
> > - Fixed coding style
> > - Squash all patches into one mfd patch
> > - Call devm_mfd_add_devices multiple times to clean up the code
> > - Remove debug prints and fixup other messages
> > - Use new_probe instead of probe
> >
> > MAINTAINERS | 1 +
> > drivers/mfd/Kconfig | 14 ++
> > drivers/mfd/Makefile | 1 +
> > drivers/mfd/tps65219.c | 357 +++++++++++++++++++++++++++++++++++
> > include/linux/mfd/tps65219.h | 345 +++++++++++++++++++++++++++++++++
>
> Use subject prefixes matching the subsystem (git log --oneline -- ...).

thank you for noticing, I am fixing it for the next version.

Best,
Markus