Re: [PATCH 1/3] scripts/gdb: fix lx-timerlist for struct timequeue_head change

[Jan Kiszka]

On 20.07.22 14:27, pngliu@xxxxxxxxxxx wrote:
> From: Peng Liu <liupeng17@xxxxxxxxxx>
> 
> commit 511885d7061e ("lib/timerqueue: Rely on rbtree semantics for next
> timer") changed struct timerqueue_head, and so print_active_timers()
> should be changed accordingly with its way to interpret the structure.
> 
> Signed-off-by: Peng Liu <liupeng17@xxxxxxxxxx>
> ---
>  scripts/gdb/linux/timerlist.py | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/scripts/gdb/linux/timerlist.py b/scripts/gdb/linux/timerlist.py
> index 071d0dd5a634..44e39dc3eb64 100644
> --- a/scripts/gdb/linux/timerlist.py
> +++ b/scripts/gdb/linux/timerlist.py
> @@ -43,8 +43,7 @@ def print_timer(rb_node, idx):
>  
>  
>  def print_active_timers(base):
> -    curr = base['active']['next']['node']
> -    curr = curr.address.cast(rbtree.rb_node_type.get_type().pointer())
> +    curr = base['active']['rb_root']['rb_leftmost']
>      idx = 0
>      while curr:
>          yield print_timer(curr, idx)

Looks good to me.

Reviewed-by: Jan Kiszka <jan.kiszka@xxxxxxxxxxx>

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux