Re: [PATCH 5/6] arm64: dts: imx8ulp: add mailbox node

[Krzysztof Kozlowski]

On 31/08/2022 13:00, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@xxxxxxx>
> 
> Add Sentinel (MU)Message Unit, Generic MU nodes.
> 
> Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> ---
>  arch/arm64/boot/dts/freescale/imx8ulp.dtsi | 26 ++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> index abec8ad4a8de..54ccf31896b7 100644
> --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> @@ -152,6 +152,15 @@ soc: soc@0 {
>  		#size-cells = <1>;
>  		ranges = <0x0 0x0 0x0 0x40000000>;
>  
> +		s4muap: mailbox@27020000 {
> +			compatible = "fsl,imx8ulp-mu-s4";
> +			reg = <0x27020000 0x10000>;
> +			interrupts = <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>;
> +			#mbox-cells = <2>;
> +			status = "okay";


This is not needed.

> +		};
> +
> +

Just one blank line.

>  		per_bridge3: bus@29000000 {
>  			compatible = "simple-bus";
>  			reg = <0x29000000 0x800000>;
> @@ -159,6 +168,23 @@ per_bridge3: bus@29000000 {
>  			#size-cells = <1>;
>  			ranges;
>  
Best regards,
Krzysztof