Re: [PATCH] KVM: nVMX: Reword comments about generating nested CR0/4 read shadows

From: Jim Mattson
Date: Tue Aug 30 2022 - 20:29:08 EST


On Tue, Aug 30, 2022 at 5:07 PM Sean Christopherson <seanjc@xxxxxxxxxx> wrote:
>
> Reword the comments that (attempt to) document nVMX's overrides of the
> CR0/4 read shadows for L2 after calling vmx_set_cr0/4(). The important
> behavior that needs to be documented is that KVM needs to override the
> shadows to account for L1's masks even though the shadows are set by the
> common helpers (and that setting the shadows first would result in the
> correct shadows being clobbered).
>
> This also fixes a repeated "we we" reported by Jason.
>
> Cc: Jason Wang <wangborong@xxxxxxxxxx>
> Signed-off-by: Sean Christopherson <seanjc@xxxxxxxxxx>
> ---
Reviewed-by: Jim Mattson <jmattson@xxxxxxxxxx>