Re: [PATCH -next] fs/hfsplus: Fix some kernel-doc comments

From: Randy Dunlap
Date: Tue Aug 30 2022 - 19:59:21 EST




On 8/30/22 00:42, Yang Li wrote:
> Add the description of @opf and remove @op and @op_flags in
> hfsplus_submit_bio() kernel-doc comment.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2013
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>


Reviewed-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

Thanks.

> ---
> fs/hfsplus/wrapper.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/hfsplus/wrapper.c b/fs/hfsplus/wrapper.c
> index 0b791adf02e5..6202e877f459 100644
> --- a/fs/hfsplus/wrapper.c
> +++ b/fs/hfsplus/wrapper.c
> @@ -30,8 +30,7 @@ struct hfsplus_wd {
> * @sector: block to read or write, for blocks of HFSPLUS_SECTOR_SIZE bytes
> * @buf: buffer for I/O
> * @data: output pointer for location of requested data
> - * @op: direction of I/O
> - * @op_flags: request op flags
> + * @opf: operation and flags for bio
> *
> * The unit of I/O is hfsplus_min_io_size(sb), which may be bigger than
> * HFSPLUS_SECTOR_SIZE, and @buf must be sized accordingly. On reads

--
~Randy