Re: [PATCH -next 1/4] spi: mockup: Add SPI controller testing driver

[Mark Brown]

On Fri, Aug 26, 2022 at 02:43:38PM +0000, Wei Yongjun wrote:

> @@ -0,0 +1,221 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + * SPI controller Testing Driver
> + *
> + * Copyright(c) 2022 Huawei Technologies Co., Ltd.
> + */

Please make the entire comment a C++ one so things look more
intentional.

> +	master = spi_alloc_master(&pdev->dev, sizeof(struct mockup_spi));
> +	if (!master) {
> +		pr_err("failed to alloc spi master\n");
> +		return -ENOMEM;
> +	}

Please use the new _controller() API, we're trying to remove the
use of outdated terminology.

Attachment: signature.asc
Description: PGP signature