Re: [PATCH 1/2] dt-bindings: mtd: spi-nor: Add reset-gpios property

From: Krzysztof Kozlowski
Date: Tue Aug 30 2022 - 05:23:06 EST


On 29/08/2022 12:05, Sai Krishna Potthuri wrote:
> SPI-NOR flashes have RESET pin which can be toggled using GPIO
> controller, for those platforms reset-gpios property can be used to
> reset the flash device.
>
> Signed-off-by: Sai Krishna Potthuri <sai.krishna.potthuri@xxxxxxx>
> ---
> Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> index 7149784a36ac..d2fc8e9c787f 100644
> --- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> @@ -70,6 +70,12 @@ properties:
> be used on such systems, to denote the absence of a reliable reset
> mechanism.
>
> + reset-gpios:
> + description:
> + contains a GPIO specifier.

Skip this part - obvious.

> The reset GPIO is asserted and then deasserted
> + to perform device reset. If "broken-flash-reset" is present then having
> + this property does not make any difference.

Isn't then broken-flash-reset conflicting with this one (e.g.
disallowing it)?

Best regards,
Krzysztof