Re: [PATCH] soc: mediatek: mtk-svs: Explicitly include bitfield header

[AngeloGioacchino Del Regno]

Il 30/08/22 09:37, Matthias Brugger ha scritto:
> On 29/08/2022 22:44, Nícolas F. R. A. Prado wrote:
> > Commit a92438c5a30a ("soc: mediatek: mtk-svs: Use bitfield access macros
> > where possible") introduced the use of FIELD_GET and FIELD_PREP macros,
> > which are defined in the bitfield header. Add an explicit include for it
> > so we're sure to have the symbols defined independently of the config.
> >
> > Fixes: a92438c5a30a ("soc: mediatek: mtk-svs: Use bitfield access macros where 
> > possible")
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx>
> >
> > ---
> >
> >   drivers/soc/mediatek/mtk-svs.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
> > index 64dba9f830f3..f67f3e971653 100644
> > --- a/drivers/soc/mediatek/mtk-svs.c
> > +++ b/drivers/soc/mediatek/mtk-svs.c
> > @@ -3,6 +3,7 @@
> >    * Copyright (C) 2022 MediaTek Inc.
> >    */
> > +#include <linux/bitfield.h>
> >   #include <linux/bits.h>
>
> What do we need the bits.h for?

bits.h has the definition for GENMASK(h, l), used in this file :-)

Cheers,
Angelo

> Regards,
> Matthias
>
> >   #include <linux/clk.h>
> >   #include <linux/completion.h>