Re: [PATCH v2 5/6] tty: n_gsm: name the debug bits

[Jiri Slaby]

On 23. 08. 22, 8:22, D. Starke wrote:
> From: Daniel Starke <daniel.starke@xxxxxxxxxxx>
>
> Introduce defines to name the various debug bits used within the code to
> improve readability and to make its specific use clear.
>
> Signed-off-by: Daniel Starke <daniel.starke@xxxxxxxxxxx>
> ---
>   drivers/tty/n_gsm.c | 31 +++++++++++++++++++------------
>   1 file changed, 19 insertions(+), 12 deletions(-)
>
> No changes since v1.
>
> diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
> index 5a20561c0a5d..fcf2d52d5095 100644
> --- a/drivers/tty/n_gsm.c
> +++ b/drivers/tty/n_gsm.c
> @@ -63,6 +63,13 @@
>   static int debug;
>   module_param(debug, int, 0600);
>   
> +/* Module debug bits */
> +#define DBG_DUMP	(1 << 0) /* Data transmission dump. */
> +#define DBG_CD_ON	(1 << 1) /* Always assume CD line on. */
> +#define DBG_DATA	(1 << 2) /* Data transmission details. */
> +#define DBG_ERRORS	(1 << 3) /* Details for fail conditions. */
> +#define DBG_TTY		(1 << 4) /* Transmission statistics for DLCI TTYs. */

Could you use BIT() instead?

thanks,
--
js
suse labs