Re: [PATCH 1/5] drm/bridge: anx7625: Drop of_gpio header

From: Robert Foss
Date: Mon Aug 29 2022 - 09:51:44 EST


Hi Maira,

On Fri, 12 Aug 2022 at 22:58, Maíra Canal <mairacanal@xxxxxxxxxx> wrote:
>
> This driver includes the deprecated OF GPIO header <linux/of_gpio.h>
> yet fail to use symbols from it, so drop the include.
>
> Cc: Andrzej Hajda <andrzej.hajda@xxxxxxxxx>
> Cc: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
> Cc: Robert Foss <robert.foss@xxxxxxxxxx>
> Cc: Laurent Pinchart <Laurent.pinchart@xxxxxxxxxxxxxxxx>
> Cc: Jonas Karlman <jonas@xxxxxxxxx>
> Cc: Jernej Skrabec <jernej.skrabec@xxxxxxxxx>
> Signed-off-by: Maíra Canal <mairacanal@xxxxxxxxxx>
> ---
> drivers/gpu/drm/bridge/analogix/anx7625.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> index 79fc7a50b497..d7d4ca1c8b30 100644
> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> @@ -17,7 +17,6 @@
> #include <linux/types.h>
> #include <linux/workqueue.h>
>
> -#include <linux/of_gpio.h>
> #include <linux/of_graph.h>
> #include <linux/of_platform.h>
>
> --
> 2.37.1
>

This cleanup looks good to me.

Reviewed-by: Robert Foss <robert.foss@xxxxxxxxx>