RE: [PATCH 2/2] arm64: tegra: Add user PWM support on Jetson Orin

[Sandipan Patra]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: Friday, August 26, 2022 11:05 PM
> To: Sandipan Patra <spatra@xxxxxxxxxx>; thierry.reding@xxxxxxxxx;
> Jonathan Hunter <jonathanh@xxxxxxxxxx>; robh+dt@xxxxxxxxxx;
> krzysztof.kozlowski+dt@xxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-
> tegra@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Cc: Bibek Basu <bbasu@xxxxxxxxxx>; Krishna Yarlagadda
> <kyarlagadda@xxxxxxxxxx>
> Subject: Re: [PATCH 2/2] arm64: tegra: Add user PWM support on Jetson
> Orin
> 
> External email: Use caution opening links or attachments
> 
> 
> On 26/08/2022 15:17, Sandipan Patra wrote:
> > Enable in device tree and use it to drive the PWM controllers on
> > 40 pin header of Orin dev-kit.
> >
> > Signed-off-by: Sandipan Patra <spatra@xxxxxxxxxx>
> > ---
> >  .../arm64/boot/dts/nvidia/tegra234-p3737-0000.dtsi | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000.dtsi
> b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000.dtsi
> > index a85993c85e45..e76894574d32 100644
> > --- a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000.dtsi
> > +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000.dtsi
> > @@ -2,4 +2,18 @@
> >
> >  / {
> >       compatible = "nvidia,p3737-0000";
> > +
> > +     bus@0 {
> > +             pwm@3280000 {
> > +                     status = "okay";
> > +             };
> 
> Overriding by node path is error-prone. You should override by label.
ACK.

Thanks & Regards,
Sandipan

> 
> Best regards,
> Krzysztof