Re: [PATCH net-next,v2] net: sched: remove redundant NULL check in change hook function

From: Toke Høiland-Jørgensen
Date: Mon Aug 29 2022 - 04:34:47 EST


Zhengchao Shao <shaozhengchao@xxxxxxxxxx> writes:

> Currently, the change function can be called by two ways. The one way is
> that qdisc_change() will call it. Before calling change function,
> qdisc_change() ensures tca[TCA_OPTIONS] is not empty. The other way is
> that .init() will call it. The opt parameter is also checked before
> calling change function in .init(). Therefore, it's no need to check the
> input parameter opt in change function.
>
> Signed-off-by: Zhengchao Shao <shaozhengchao@xxxxxxxxxx>

for sch_cake:

Acked-by: Toke Høiland-Jørgensen <toke@xxxxxxx>