Re: [PATCH v4] arm64: dts: qcom: sc7280: Fix Dmic no sound on villager-r1

From: Stephen Boyd
Date: Fri Aug 26 2022 - 14:08:50 EST


Quoting Judy Hsiao (2022-08-25 23:56:21)
> Fix the DMIC no sound issue of villager-r1 by using "PP1800_L2C" as the
> DMIC power source to match the hardware schematic.
>
> This patch:
> 1. set vdd-micb-supply to PP1800_L2C as the MIC Bias voltage regulator.
> 2. In audio-routing, set VA DMIC01~VA DMIC03 to use the vdd-micb-supply
> setting.
>
> Co-developed-by: Srinivasa Rao Mandadapu <quic_srivasam@xxxxxxxxxxx>
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@xxxxxxxxxxx>
> Signed-off-by: Judy Hsiao <judyhsiao@xxxxxxxxxxxx>

Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>

> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts
> index c03b3ae4de50..fd202a8f6a33 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts
> @@ -12,3 +12,30 @@ / {
> model = "Google Villager (rev1+)";
> compatible = "google,villager", "qcom,sc7280";
> };
> +
> +&lpass_va_macro {
> + vdd-micb-supply = <&pp1800_l2c>;
> +};

I wonder if we'll want to move this to some common "lpass audio" mixin
dtsi file, but we can do that later.