Re: [PATCH v2 1/2] dt-bindings: lan9662-otpc: document Lan9662 OTPC

From: Horatiu Vultur
Date: Fri Aug 26 2022 - 03:27:10 EST


The 08/26/2022 09:42, Krzysztof Kozlowski wrote:

Hi Krzysztof,

> > +properties:
> > + compatible:
> > + items:
> > + - const: microchip,lan9662-otpc
> > + - const: microchip,lan9668-otpc
>
> Does not look like you tested the bindings. Please run `make
> dt_binding_check` (see
> Documentation/devicetree/bindings/writing-schema.rst for instructions).
>
> This won't work...

You are right. That was a silly mistake on my side.

It should be:
---
properties:
compatible:
enum:
- microchip,lan9662-otpc
- microchip,lan9668-otpc
---
Because what I want to achive is to be able to use any of
string(microchip,lan9662-otpc or microchip,lan9668-otpc) as compatible
string.

Or this is not the correct change?
At least with this change dt_binding_check is happy.

>
> Best regards,
> Krzysztof

--
/Horatiu