RE: [RFC PATCH] usb: reduce kernel log spam on driver registration

[Alim Akhtar]

>-----Original Message-----
>From: Russell King (Oracle) [mailto:linux@xxxxxxxxxxxxxxx]
>Sent: Thursday, August 25, 2022 11:40 PM
>To: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>
>Cc: 'Ard Biesheuvel' <ardb@xxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx;
>'Alexandre Belloni' <alexandre.belloni@xxxxxxxxxxx>; linux-samsung-
>soc@xxxxxxxxxxxxxxx; 'Tomer Maimon' <tmaimon77@xxxxxxxxx>; linux-
>omap@xxxxxxxxxxxxxxx; 'Avi Fishman' <avifishman70@xxxxxxxxx>; 'Greg
>Kroah-Hartman' <gregkh@xxxxxxxxxxxxxxxxxxx>; linux-usb@xxxxxxxxxxxxxxx;
>'Tali Perry' <tali.perry1@xxxxxxxxx>; 'Nancy Yuen' <yuenn@xxxxxxxxxx>;
>'Krzysztof Kozlowski' <krzysztof.kozlowski@xxxxxxxxxx>; 'Alan Stern'
><stern@xxxxxxxxxxxxxxxxxxx>; 'Patrice Chotard'
><patrice.chotard@xxxxxxxxxxx>; 'Patrick Venture' <venture@xxxxxxxxxx>;
>'Vladimir Zapolskiy' <vz@xxxxxxxxx>; 'Claudiu Beznea'
><claudiu.beznea@xxxxxxxxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
>'Benjamin Fair' <benjaminfair@xxxxxxxxxx>
>Subject: Re: [RFC PATCH] usb: reduce kernel log spam on driver registration
>
>On Thu, Aug 25, 2022 at 10:53:44PM +0530, Alim Akhtar wrote:
>> >Drivers are typically supposed to be quiet unless they are actually
>> >probed,
>> but
>> >for some reason, USB host controllers seem to be exempt from this
>> >rule, and happily broadcast their existence into the kernel log at
>> >boot even if the hardware in question is nowhere to be found.
>> >
>> >Let's fix that, and remove these pr_info() calls.
>> >
>> How about just change pr_info() to pr_debug() instead?
>
>Do the messages serve a useful purpose that the initcall_debug kernel
>parameter (that doesn't require #define DEBUG to be set while compiling and
>thus can be used with any kernel) doesn't provide?
>
Ah, right,  initcall_debug will do the job.
So removing pr_info() from init call looks good.
Thanks.

Hi Ard
Feel free to add 

Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>


>--
>RMK's Patch system: https://protect2.fireeye.com/v1/url?k=3b37dc19-
>5abcc93c-3b365756-74fe485cbff6-6a25f0b5c8476bae&q=1&e=752dac9b-cfef-
>4919-8665-
>8a220aac5d96&u=https%3A%2F%2Fwww.armlinux.org.uk%2Fdeveloper%2Fp
>atches%2F
>FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!