Re: [PATCH v3 1/5] soc: qcom: llcc: Rename reg_offset structs to reflect LLCC version

[Sai Prakash Ranjan]

On 8/25/2022 10:08 AM, Manivannan Sadhasivam wrote:
> The register offsets used by the LLCC block retains its layout for multiple
> versions. For instance, starting from version v1.0.0 to v2.0.1 the offsets
> are same. And starting from v2.1.0, the offsets changed.
>
> But the current reg_offset naming convention is confusing. So to reflect
> this change correctly in driver, let's encode the start version from which
> the offsets got changed in reg_offset struct name. This will be
> llcc_v1_reg_offset for v1.0.0 and llcc_v2_1_reg_offset for v2.1.0.
> This will allow multiple SoCs to use the same reg_offset clearly.
>
> And in the future if the offsets got changed again, then that specific
> version could be encoded in the struct name.
>
> Suggested-by: Sai Prakash Ranjan <quic_saipraka@xxxxxxxxxxx>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> ---
>   drivers/soc/qcom/llcc-qcom.c | 26 ++++++++++++++------------
>   1 file changed, 14 insertions(+), 12 deletions(-)

Reviewed-by: Sai Prakash Ranjan <quic_saipraka@xxxxxxxxxxx>


Thanks,
Sai