Re: [PATCH bpf-next] selftests/bpf: fix incorrect fcntl call

[Alexei Starovoitov]

On Wed, Aug 24, 2022 at 8:13 AM Mykola Lysenko <mykolal@xxxxxx> wrote:
>
> Hi Qiao,
>
> > On Aug 24, 2022, at 7:01 AM, Qiao Ma <mqaio@xxxxxxxxxxxxxxxxx> wrote:
> >
> > !-------------------------------------------------------------------|
> >  This Message Is From an External Sender
> >
> > |-------------------------------------------------------------------!
> >
> > To set socket noblock, we need to use
> >> fcntl(fd, F_SETFL, O_NONBLOCK);
> > rather than:
> >> fcntl(fd, O_NONBLOCK);
>
> Can you please add more description on what is it fixing?
>
> Additionally, add file name to the title to make it easier to identify the commit from oneline git log.

file name in commit log? I think it's overkill.
The file names can be seen with git log --stat
Let's not put duplicate info into subjects.

> Something like “selftests/bpf: fix incorrect fcntl call (test_sockmap.c)”.